[14.0][FIX] shopinvader_membership subscribe#1207
[14.0][FIX] shopinvader_membership subscribe#1207acsonefho wants to merge 1 commit intoshopinvader:14.0from
Conversation
|
@acsonefho a little bit of explanation would not hurt ;) So this fixes the following error: |
|
@acsonefho What's the status of this ?? |
7f6cead to
f30e2dd
Compare
|
LGTM. Test are red, though. Can you post a screenshot of the swagger ? BTW, I take the opportunity to remind that these services exposing standard Odoo or OCA features that are not related to shopinvader don't need a dependency on |
f30e2dd to
f29efdc
Compare
|
Do we need to keep the |
|
And can you show a screenshot of the input form swagger is creating for the POST ? I'm not entirely fluent in cerberus :) |
I update the documentation. I update the GET with a deprecated (+ also add a warning into logs when this GET is used). |
f29efdc to
b831ff8
Compare
| wizard = self.env["membership.invoice"].create( | ||
| {"product_id": _id, "member_price": membership_product.list_price} | ||
| {"product_id": product_id, "member_price": membership_product.list_price} | ||
| ) |
There was a problem hiding this comment.
One last thing: I'd rather avoid using the wizard and call res.partner.create_membership_invoice() instead. The code will be easier to understand and the wizard will stay where it needs to stay (i.e. in the UI realm and not the business logic realm).
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |


No description provided.